Disable drift, pingpong and io tests to clean up Swift CI #158
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Aug 19, 2016
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We're still getting some intermitted failures in the Swift CI which we've not been able to recreate locally (on a 38-way machine).
These are in:
dispatch_pingpong- this results in a hangdispatch_drift- this fails because we exceed the drift thresholdAdditionally,
dispatch_ioalways fails in the CI builds on Ubuntu 14.04 where it runs out of file descriptors. I've run the tests on Ubuntu 14.04 and and 15.10 locally, and can't find any evidence that we're leaking file descriptors - it looks like the Swift CI's hard limit for NOFILES is too low.In order to clean up the CI quickly, I'm proposing that we disable all three tests. We can then fix the CIs configuration and debug the tests once we've got Swift 3.0 done.